fix: circular dependency

[TalDerei]

References #3389. This PR migrates the benches from proof-params to a dedicated bench package and removes any unnecessary dev-dependencies to bypass the circular dependency bug that breaks rust-analyzer.

[conorsch]

CI looks happy, which is a great sign. If I run cargo bench locally, however, I see a bunch of warnings:

❯ cargo bench
warning: invalid feature `proving-keys` in required-features of target `nullifier_derivation`: `proving-keys` is not present in [features] section
warning: invalid feature `proving-keys` in required-features of target `output`: `proving-keys` is not present in [features] section
warning: invalid feature `proving-keys` in required-features of target `delegator_vote`: `proving-keys` is not present in [features] section
warning: invalid feature `proving-keys` in required-features of target `spend`: `proving-keys` is not present in [features] section
warning: invalid feature `proving-keys` in required-features of target `swap`: `proving-keys` is not present in [features] section
warning: invalid feature `proving-keys` in required-features of target `swap_claim`: `proving-keys` is not present in [features] section
warning: invalid feature `proving-keys` in required-features of target `undelegate_claim`: `proving-keys` is not present in [features] section
   Compiling penumbra-custody v0.63.1 (/home/conor/src/penumbra/crates/custody)
   Compiling penumbra-view v0.63.1 (/home/conor/src/penumbra/crates/view)
   Compiling narsil v0.63.1 (/home/conor/src/penumbra/crates/narsil/narsil)
   Compiling pd v0.63.1 (/home/conor/src/penumbra/crates/bin/pd)
[...snip...]

I made sure to confirm that these warnings do not appear on main. Anything we can do to clean them up? Once we're happy with the substantive changes, please make sure to edit the docs to make sure the correct directories and commands are specified, e.g. at https://guide.penumbra.zone/main/dev/parameter_setup.html, the source for which you can find at docs/guide/src/dev/parameter_setup.md.

[cronokirby]

I don't want to bikeshed too hard either, but conceptually it is sort of weird to have these things in proof-setup, which is basically just the internal math necessary for the summoning ceremony. The reason that crate has a dependency on the circuits is just to calculate their size.

[cronokirby]

I think the ideal thing would be to have benches at the monorepo level, which can then take in any crate they want for whatever reason.

[TalDerei]

@conorsch I just noticed this as well. Per #3337, it'll require passing in the

penumbra-proof-params = { path = "../../crypto/proof-params", features = [
    "bundled-proving-keys",
    "download-proving-keys",
] }

dependency to the Cargo file. Right now, it requires a slightly different feature proving-keys to be present. I'll incorporate the change.

@cronokirby I agree. I sort of put the benches there as a placeholder to satisfy the CI, but moving it should be simple. I'll make that change as well.

[TalDerei]

I had to merge the commits from #3389 to pass the CI and prevent the changes in this branch from breaking once #3389 is merged into master. Keeping this PR as a draft until the other PR is approved and merged.

[TalDerei]

Ready for review!

[cronokirby]

I like the approach here; let's rebase and then get this merged

[conorsch]

One more thing: when I run cargo bench on this branch, it updates the workspace's Cargo.lock. The changes to that file should be committed and added to this PR. Other than that, LGTM!

[conorsch]

I'm going to do a bit of housekeeping on the commit history here, then merge.