refactor(wasm): clean up split-up build #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
approved these changes
Nov 17, 2023
|
|
||
| [dev-dependencies] | ||
| wasm-bindgen-test = "0.3.37" | ||
| wasm-bindgen-test = "0.3.37" | ||
| serde_json = "1.0.107" |
| @@ -41,7 +43,16 @@ impl IndexedDBStorage { | |||
| pub async fn new(constants: IndexedDbConstants) -> WasmResult<Self> { | |||
| let mut db_req: OpenDbRequest = IdbDatabase::open_u32(&constants.name, constants.version)?; | |||
|
|
|||
| // Conditionally create object stores in the `IdbDatabase` database for testing purposes | |||
| // Conditionally mock sample `IdbDatabase` database for testing purposes | |||
| #[cfg(feature = "mock-database")] | |||
There was a problem hiding this comment.
ah, nice call with the feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #3406.
For testing purposes, we can conditionally mock a sample
IdbDatabasedatabase using themock-databasefeature. This enables stripping out unnecessary business logic from the production code. The command to run the test suite iswasm-pack test --chrome -- --test test_build --target wasm32-unknown-unknown --release --features "mock-database"inside the wasm package.