Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summonerd: don't bail out on bad contribution data #3434

Merged

Conversation

hdevalence
Copy link
Member

The better code pattern for this would be to blanket-handle errors in the method, but at the moment it seems better to just fix the current issue.

The better code pattern for this would be to blanket-handle errors in the method, but at the moment it seems better to just fix the current issue.
@hdevalence hdevalence merged commit 3bf0609 into summonerd-feature-branch Nov 25, 2023
7 of 8 checks passed
@hdevalence hdevalence deleted the summonerd-handle-deserialization-error branch November 25, 2023 22:55
conorsch pushed a commit that referenced this pull request Dec 8, 2023
The better code pattern for this would be to blanket-handle errors in the method, but at the moment it seems better to just fix the current issue.
conorsch pushed a commit that referenced this pull request Dec 8, 2023
The better code pattern for this would be to blanket-handle errors in the method, but at the moment it seems better to just fix the current issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant