Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wasm): try_load_unchecked method #3458

Merged
merged 1 commit into from
Dec 1, 2023
Merged

refactor(wasm): try_load_unchecked method #3458

merged 1 commit into from
Dec 1, 2023

Conversation

TalDerei
Copy link
Collaborator

@TalDerei TalDerei commented Dec 1, 2023 •
edited
Loading

The purpose of try_load_unchecked is to bypass the expensive hash operation used for fingerprinting the proving keys in WASM. This reduces the load_proving_key call times by 80%.

@TalDerei TalDerei self-assigned this Dec 1, 2023
@TalDerei TalDerei requested a review from hdevalence December 1, 2023 07:34
@TalDerei TalDerei marked this pull request as ready for review December 1, 2023 07:34
@TalDerei
Copy link
Collaborator Author

TalDerei commented Dec 1, 2023

@grod220 fyi

@hdevalence hdevalence merged commit 5c8276a into main Dec 1, 2023
7 checks passed
@hdevalence hdevalence deleted the load-keys-unchecked branch December 1, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdevalence hdevalence Awaiting requested review from hdevalence

Assignees

@TalDerei TalDerei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalDerei @hdevalence