-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs related to transaction build process #3463
Conversation
One thing that's a little awkward is that now we don't actually have a different state, it's just a transaction (with invalid data in it). Not sure the best way to handle this in the docs. |
signatures from the `AuthorizationData` are ready[^1]. This intermediate state | ||
of the transaction without the full authorizing data is called the `UnauthTransaction`. | ||
of the transaction without the full authorizing data is referred to as the `UnauthenticatedTransaction`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we should probably say "unauthenticated Transaction
", right, since there's no distinct data type / message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, changed
It might be better to describe it as a state transition in terms of the |
References #3401
transaction_signing.md
doc is modified to describe the build process in more detail according to the changes in #3289. Additionally, since theUnauthTransaction
type was removed, I propose changing the intermediate state of a transaction toUnauthenticated Transaction
orPending Transaction
for improved clarity.