-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(transaction): Implement canonical ordering in TransactionPlan
#3467
Conversation
We should also have tie breaking based on the effect hash, rather than just using whatever order between actions that happens to exist (or perhaps something more intricate). Because of this, it might be a good idea to instead shift the approach of this PR to adding an Eq and Ord instance to Action based on this philosophy. |
Let's pause work on this until having a better spec of what should be done, it's relatively less important than other changes we should be focusing on right now (getting new builder code integrated into web extension, making breaking changes before next testnet release). |
This PR is blocked and will remain as a draft until after the next release. |
We are not planning to merge this for Testnet 64, so we'll return to it next week. |
Is this something we want done for the next testnet release? otherwise it can remain in the backlog |
Let's keep it in the backlog for now |
Signed-off-by: Tal Derei <70081547+TalDerei@users.noreply.github.com>
Signed-off-by: Tal Derei <70081547+TalDerei@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
References #3435 and #3379