Fetch and store transactions from pd storage
#3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
reviewed
Dec 5, 2023
zbuc
force-pushed
the
3451_index_cometbft_blocks
branch
from
40ba5d5 to
ac14d17
Compare
hdevalence
reviewed
Dec 5, 2023
Comment on lines
+203
to
+206
| // An authorization hash for a Penumbra transaction. | ||
| message EffectHash { | ||
| bytes inner = 1; | ||
| } |
There was a problem hiding this comment.
Side note: I think we might want to split the effect hash code into its own crate, rather than putting it in the transaction crate. The reason is that all of the components need to be able to define their effecting data, but the overarching transaction crate depends on all the components.
hdevalence
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
pcli's reliance on theget_block_by_heightmethod since it can't persist data after a chain upgrade occurs. Since it was only using this to fetch transaction data during sync, the transaction data is all that we need to record.All block transactions will be recorded in nonverifiable storage in a new
cometbft-datasubstore.Closes #3451