Start pruning content out of the penumbra-chain crate
#3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
changed the title
penumbra-chain cratepenumbra-chain crate
|
This is a reasonable start and doesn't depend on further changes. |
hdevalence
commented
Dec 5, 2023
Comment on lines
+17
to
+18
| pub raw_amount: Amount, | ||
| pub raw_denom: String, |
There was a problem hiding this comment.
I changed these to raw_ to reflect that they might be in units that need adjustment. This is not a great pattern -- we should avoid using Amount for anything other than an amount of the base denom -- but it's probably okay here because it's only for the genesis data, which has to be trusted anyways.
hdevalence
commented
Dec 5, 2023
| @@ -918,12 +919,15 @@ impl<T: StateWrite + StateWriteExt + ?Sized> StakingImpl for T {} | |||
|
|
|||
| #[async_trait] | |||
| impl Component for Staking { | |||
| type AppState = GenesisContent; | |||
| type AppState = (GenesisContent, ShieldedPoolGenesisContent); | |||
There was a problem hiding this comment.
In this way, components can reference other components' genesis data.
conorsch
added a commit
that referenced
this pull request
Dec 6, 2023
Follow up to #3474, to satisfy buf linting CI check.
conorsch
added a commit
that referenced
this pull request
Dec 6, 2023
Follow up to #3474, to satisfy buf linting CI check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a catch-all crate at the bottom of the component dependency tree, and it'd be clearer to get rid of it and move the code into places where it belongs.