Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proto): remove asset import in chain protos #3487

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(proto): remove asset import in chain protos #3487

merged 1 commit into from
Dec 6, 2023

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Dec 6, 2023

Follow up to #3474, to satisfy buf linting CI check.

@conorsch
fix(proto): remove asset import in chain protos
1df932e 
Follow up to #3474, to
satisfy buf linting CI check.
@conorsch
Copy link
Contributor Author

conorsch commented Dec 6, 2023

Weirdly I've removed the unnecessary import but CI is still flagging it:

ci-buf-lint-what

I've confirmed that buf lint doesn't report this error on this branch locally, while it does still flag it on main, and that's good enough for me, so I'm going to merge this once the smoke test passes (which is a useful sanity check here) and rebase other PRs.

This was referenced Dec 6, 2023
Merged
Merged
@conorsch conorsch merged commit a9f9e9b into main Dec 6, 2023
6 of 7 checks passed
@conorsch conorsch deleted the proto-asset-removal branch December 6, 2023 21:20
@cratelyn cratelyn added the protobuf-changes Makes changes to the protobuf definitions. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
protobuf-changes Makes changes to the protobuf definitions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conorsch @cratelyn