Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add randomized BatchSwapOutputData in SwapClaim proptests #3490

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

redshiftzero
Copy link
Member

Closes #3480

Comment on lines +451 to +452
let delta_1 = (4001..2000000000u128).prop_map(Amount::from);
let delta_2 = (4001..2000000000u128).prop_map(Amount::from);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have such a large range?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not that big if you account for the denom scaling factors, typically 10^6, 10^9 or 10^18 (!)

@redshiftzero redshiftzero merged commit dbe8abf into main Dec 11, 2023
7 checks passed
@redshiftzero redshiftzero deleted the test-swap-claim branch December 11, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add additional test coverage of the SwapClaim proof
3 participants