pd(upgrade): create fresh validator state and accept --genesis-start
#3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
approved these changes
Dec 7, 2023
| let mut genesis_path = path_to_export.clone(); | ||
| genesis_path.push("genesis.json"); | ||
| std::fs::write(genesis_path, genesis_json).expect("can write genesis"); | ||
| let genesis_json = serde_json::to_string(&genesis).expect("can serialize genesis"); |
There was a problem hiding this comment.
Nit: because this fn is fallible already, we should be using .context rather than .expect. but that was true before this PR, so let's not block on it. Mostly sounding you out for agreement, so I can look for opportunities to reshape next time I'm in here.
| let mut validator_state_path = path_to_export.clone(); | ||
| validator_state_path.push("priv_validator_state.json"); | ||
| let fresh_validator_state = | ||
| crate::testnet::generate::TestnetValidator::initial_state(); |
There was a problem hiding this comment.
Beautiful, this'll solve our problems! As an aside, is there any kind of chain upgrade where we wouldn't want the validator state reset? I can't think of one.
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
SimpleUpgrademigration script generate a fresh validator state file to populate comet's view of the validator data. It also adds an optional--genesis-startflag topd upgradeto help testing with multinode setups.