ibc: extend prehash_key_before_comparison hack for new substore spec #3493
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
reviewed
Dec 8, 2023
| @@ -233,6 +233,7 @@ pub fn validate_penumbra_client_state( | |||
| // allow legacy proof specs without prehash_key_before_comparison | |||
| let mut spec_with_prehash_key = tm_client_state.proof_specs.clone(); | |||
| spec_with_prehash_key[0].prehash_key_before_comparison = true; | |||
| spec_with_prehash_key[0].prehash_key_before_comparison = true; | |||
There was a problem hiding this comment.
i think that's a typo it should be [1] right?
avahowell
force-pushed
the
remaining-ibc-fixes
branch
from
4a80bf3 to
d14d904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're using two JMT specs now, we need to extend the legacy mode to allow both to have no
prehash_key_before_comparison.