shielded-pool: use typed Nullifier in EventSpend #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
erwanor
force-pushed
the
nullifier-proto-in-events
branch
from
94bbbf3 to
16479c8
Compare
This is technically a breaking change but I think we should pretend it isn't, since it only affects events, and we never parse the events. So cleaning it up now is an opportunity to do a fix with minimal breakage.
erwanor
force-pushed
the
nullifier-proto-in-events
branch
from
16479c8 to
c24ac41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change but I think we should pretend it isn't, since it only affects events, and we never parse the events. So cleaning it up now is an opportunity to do a fix with minimal breakage.