Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename effecthash crate to txhash #3548

Merged
merged 5 commits into from
Jan 1, 2024
Merged

Rename effecthash crate to txhash #3548

merged 5 commits into from
Jan 1, 2024

Conversation

hdevalence
Copy link
Member

This allows us to put not just the effect hash but also the auth hash and
transaction ID, letting other parts of the source tree reference transaction
IDs without depending on the transaction crate.

This allows us to put not just the effect hash but also the auth hash and
transaction ID, letting other parts of the source tree reference transaction
IDs without depending on the transaction crate.
@hdevalence
Copy link
Member Author

The "Compile protobuf specs to rust code" fails, but there are no changes locally:

~/c/p/penumbra2 (txhash-crate|✔) $ ./deployments/scripts/protobuf-codegen
Cleaning output dirs...
Pulling proto dependencies from BSR...
~/code/penumbra/penumbra2/proto ~/code/penumbra/penumbra2
Generating golang code...
~/code/penumbra/penumbra2
Generating rust code...
~/code/penumbra/penumbra2/tools/proto-compiler ~/code/penumbra/penumbra2
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `target/debug/penumbra-proto-compiler`
root: /Users/hdevalence/code/penumbra/penumbra2/tools/proto-compiler
target_dir: /Users/hdevalence/code/penumbra/penumbra2/tools/proto-compiler/../../crates/proto/src/gen
cnidarium_target_dir: /Users/hdevalence/code/penumbra/penumbra2/tools/proto-compiler/../../crates/cnidarium/src/gen
~/code/penumbra/penumbra2
Finished! Consider running a 'cargo check --release' to confirm builds still work.

Changing the CI workflow to add a git diff to actually show what the changes are results in the entire workflow not running (?).

@hdevalence hdevalence merged commit e10e07d into main Jan 1, 2024
5 checks passed
@hdevalence hdevalence deleted the txhash-crate branch January 1, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant