chore: cargo lint #3566
Merged
chore: cargo lint #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
3543-rust-lints
branch
from
7636c09 to
442ce6d
Compare
|
Downgrading to draft because @cronokirby noticed we weren't checking the benchmarks, and #3556 made some changes that now cause lints to fail. |
conorsch
force-pushed
the
3543-rust-lints
branch
from
442ce6d to
e260f6e
Compare
Satisfies the latest cargo lints. I took the easy way out, preserving the existing function sigs, rather than performing a deeper refactor. Ignored the checks on the re-export of metrics code across components. Holding off on adding `--all-targets` to the check command, because there's some cleanup to do in the benchmarks, related to #3556. Revert "ci: disable -D warnings" This reverts commit 4e7c77b. Refs #3543.
conorsch
force-pushed
the
3543-rust-lints
branch
from
e260f6e to
ffabb1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfies the latest cargo lints. I took the easy way out, preserving the existing function sigs, rather than performing a deeper refactor. Ignored the checks on the re-export of metrics code across components.
Holding off on adding
--all-targetsto the check command, because there's some cleanup to do in the benchmarks, related to #3556.Revert "ci: disable -D warnings"
This reverts commit 4e7c77b.
Refs #3543.