MemoPlaintext string length enforced, TransactionPlan panic avoided #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbocrime
commented
Jan 8, 2024
Comment on lines
-71
to
+74
| let memo_hash = self | ||
| .memo | ||
| .as_ref() | ||
| .map(|memo_plan| { | ||
| memo_plan | ||
| .memo() | ||
| .expect("can compute memo ciphertext") | ||
| .effect_hash() | ||
| }) | ||
| // If the memo is not present, use the all-zero hash to record its absence in | ||
| // the overall effect hash. | ||
| .unwrap_or_default(); | ||
| let memo_hash = match self.memo { | ||
| Some(ref memo) => memo.memo()?.effect_hash(), | ||
| None => EffectHash::default(), | ||
| }; |
There was a problem hiding this comment.
this is a significant change in style compared to the previous implementation, not sure if that's appropriate
There was a problem hiding this comment.
I like the result of the change better, it's more succinct this way.
cronokirby
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identified a panic when working on web transactions.
added checks to verify text length is under maximum when deserializing from
pbt::MemoPlaintextorVec<u8>, to prevent the creation of impossible memos. perhapsMemoPlaintextshould use private fields and a constructor to enforce format limitations that cannot be specified by protobuf, but this is a smaller change.ultimately the source of the panic was an
expectused inTransactionPlan::effect_hashto unwrap a potential error, this is now bubbled asanyhow::Result