ibc host chain interface v2 #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avahowell
had a problem deploying
to
smoke-test
GitHub Actions
Failure
avahowell
had a problem deploying
to
smoke-test
GitHub Actions
Failure
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Failure
avahowell
had a problem deploying
to
smoke-test
GitHub Actions
Failure
avahowell
changed the title
avahowell
force-pushed
the
ibc-host-chain-interface-v2
branch
from
61625a4 to
509bb68
Compare
|
let me know when this is ready for another round of review @avahowell! 🔍 🙂 |
|
this should be ready for another round of review now! |
erwanor
reviewed
Jan 16, 2024
cratelyn
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
this looks good to me! i spotted a stray comment that i believe is stale, but the mechanical changes here all seem well-written. great work @avahowell!
cratelyn
approved these changes
Jan 17, 2024
avahowell
force-pushed
the
ibc-host-chain-interface-v2
branch
from
d349926 to
40b6bf1
Compare
noot
added a commit
to astriaorg/astria
that referenced
this pull request
Jan 29, 2024
## Summary need to set specific state keys on `InitChain` and `BeginBlock` for the IBC impl to work. also uses the `HostInterface` implemented here: penumbra-zone/penumbra#3598 needed so that the IBC impl can access astria-specific state keys. ## Background as above ## Changes - use the penumbra `IBCComponent` within our app, which deals with the required IBC state - implement `HostInterface` for `AstriaHost` ## Testing with hermes (see https://www.notion.so/astria-org/IBC-setup-local-between-Astria-and-Celestia-4cfea753490e4a7f85833e9b3f629ccb?pvs=4) ## Breaking Changelist this updates the values in storage (adds `chain_id`) ## Related Issues closes #650 (not exactly related but closing anyways, don't need to explicitly bind `transfer` ports as this is checked in the penumbra IBC implementation (`PortId::transfer()`))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.