Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provenance storage fix #3604

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Provenance storage fix #3604

merged 8 commits into from
Jan 23, 2024

Conversation

aubrika
Copy link
Contributor

@aubrika aubrika commented Jan 12, 2024

Closes #3568

@aubrika aubrika force-pushed the provenance-storage-fix branch from c12a5e2 to 6dbd56e Compare January 12, 2024 01:34
@aubrika aubrika force-pushed the provenance-storage-fix branch from 6dbd56e to 5b7b900 Compare January 12, 2024 01:41
@cronokirby cronokirby force-pushed the provenance-storage-fix branch from 5b7b900 to 7782fe7 Compare January 22, 2024 19:11
@cronokirby cronokirby force-pushed the provenance-storage-fix branch from 7782fe7 to d5879b4 Compare January 22, 2024 19:24
@cronokirby cronokirby marked this pull request as ready for review January 22, 2024 21:43
@conorsch
Copy link
Contributor

After much heroic wrangling with CI by @cronokirby (see https://discord.com/channels/824484045370818580/1044394105498771506/1199092033667743754 for context), we expect green across the board here, after which we can merge.

hdevalence and others added 8 commits January 23, 2024 09:23
This currently doesn't populate the data, it just makes it available in the
protos.  There's some work to be done on the Rust view server and in the web
extension to populate this proto field with meaningful data.
…clude additional tx_hash column for provenance
@conorsch
Copy link
Contributor

This PR resolves #3568, right? Do we still want #3569, or does this PR supersede that one?

@aubrika
Copy link
Contributor Author

aubrika commented Jan 23, 2024

This supersedes that one, I made a new branch so I could isolate my changes but I'll close the prior PR - and yes, this should close #3568

@aubrika aubrika merged commit 5a2b686 into main Jan 23, 2024
7 checks passed
@aubrika aubrika deleted the provenance-storage-fix branch January 23, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoteSource changes broke notes_by_sender and hence the summoner
4 participants