-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provenance storage fix #3604
Merged
Merged
Provenance storage fix #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubrika
force-pushed
the
provenance-storage-fix
branch
from
January 12, 2024 01:34
c12a5e2
to
6dbd56e
Compare
aubrika
force-pushed
the
provenance-storage-fix
branch
from
January 12, 2024 01:41
6dbd56e
to
5b7b900
Compare
cronokirby
force-pushed
the
provenance-storage-fix
branch
from
January 22, 2024 19:11
5b7b900
to
7782fe7
Compare
cronokirby
had a problem deploying
to
smoke-test
January 22, 2024 19:11 — with
GitHub Actions
Failure
cronokirby
had a problem deploying
to
smoke-test
January 22, 2024 19:17 — with
GitHub Actions
Failure
cronokirby
force-pushed
the
provenance-storage-fix
branch
from
January 22, 2024 19:24
7782fe7
to
d5879b4
Compare
cronokirby
had a problem deploying
to
smoke-test
January 22, 2024 19:26 — with
GitHub Actions
Failure
cronokirby
had a problem deploying
to
smoke-test
January 22, 2024 20:43 — with
GitHub Actions
Failure
cronokirby
had a problem deploying
to
smoke-test
January 22, 2024 21:43 — with
GitHub Actions
Failure
cronokirby
had a problem deploying
to
smoke-test
January 22, 2024 23:20 — with
GitHub Actions
Failure
After much heroic wrangling with CI by @cronokirby (see https://discord.com/channels/824484045370818580/1044394105498771506/1199092033667743754 for context), we expect green across the board here, after which we can merge. |
This currently doesn't populate the data, it just makes it available in the protos. There's some work to be done on the Rust view server and in the web extension to populate this proto field with meaningful data.
…clude additional tx_hash column for provenance
cronokirby
force-pushed
the
provenance-storage-fix
branch
from
January 23, 2024 17:23
083f4a9
to
dc7daaf
Compare
This supersedes that one, I made a new branch so I could isolate my changes but I'll close the prior PR - and yes, this should close #3568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3568