-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protobuf): authorizeAndBuild method #3618
Conversation
@conorsch how can I satisfy the CI here? the breaking change is intentional |
Why are we getting rid of this RPC? Just because the web extension isn't planning to use it doesn't mean we should lock users out of a split custody setup... |
good point, I should have clarified. That RPC method won't specifically be used for sending transactions in the web extension. I reverted the change in the web and added comments. |
@hdevalence should we proceed with this change? |
Yep, let's get rid of the erroneous argument I added via copy paste error, but leave the RPC in place. |
You cannot, the CI is red because it's telling us "this is a breaking change." We know that, and we accept the breaking change and its implications, so what I'll do it override the merge control and get it into main anyway. However, merge is also blocked due to conflicts, so this needs to be freshly rebased on main (at least #3559, merged today, will have introduced conflicts). Can you rebase and mark ready for review? |
Spoke with @TalDerei out of band, I'm going to rebase and get this to green (modulo the proto lint). |
2ebcf1c
to
5be65ed
Compare
CI is good here. I'm holding off on merge so that @TalDerei can perform a bit more testing locally. |
Tal confirmed good to go, so I'm merging to unblock further work in web world. |
We're eventually deprecating
witnessAndBuild
in favor of theauthorizeAndBuild
RPC method, and it unnecessarily requires anauthorizationData
field in order to be invoked. This modification of the protobuf definition is a necessary precursor for penumbra-zone/web#369.cc @grod220 @turbocrime