ci: fix ingress svc name #3649
Merged
ci: fix ingress svc name #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to 1d688c2, observed post-deploy that the public HTTPS endpoints weren't responding. We're preserving the old service names for convenience's sake, so let's reuse them throughout. Other than this fix, the only manual interaction required for the preview deployment to heal after the rewrite was to remove the `app=` selector label from each p2p lb. Will do that manually on testnet when the time comes, as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 1d688c2, observed post-deploy that the public HTTPS endpoints weren't responding. We're preserving the old service names for convenience's sake, so let's reuse them throughout.
Other than this fix, the only manual interaction required for the preview deployment to heal after the rewrite was to remove the
app=selector label from each p2p lb. Will do that manually on testnet when the time comes, as well.