staking: validator state transition fix #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with a missing transition (
Active->Defined) and adds context for each transition case. With that said, writing this code makes me think that we might be better off by limiting the amount of possible transitions, removingActive -> DefinedandJailed -> Definedtransition, and use end-epoch processing to "sweep" inactive validators into the precursorDefinedstate.Since I am in the middle of an assurance blitz for #3640, I will abstain from making more changes. But this is currently top-of-mind for me. Moreover, manual testing seems to surface issues with Unbonded/Unbonding (observed on
v0.64.0as well) so I plan to look into that as well.