ci: fix smoke test #3657
Merged
ci: fix smoke test #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
There were a few problems with the changes in #3656. First, the YAML workflow file was poorly indented, which caused the job not to be evaluated, so we got a false green. Beyond that, the wrapper script needed handling for an undefined var, and a tweak to the backgrounding/logging changes. All are updated, and this change passes locally.
conorsch
force-pushed
the
erwan/fix_workflow_config
branch
from
8f6bca1 to
422c403
Compare
|
Passing: https://github.com/penumbra-zone/penumbra/actions/runs/7644866555/job/20830140204 Also confirmed it passes locally. I suspect we might need to fuss with the auto-log-output functionality for stdout/stderr, but that'll only be obvious once we actually have a failing test. I'm going to merge this to unbreak the test suite for other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I introduced an indentation error, this should fix it!