Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display full address in summoner interface #3667

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

cronokirby
Copy link
Contributor

Closes #3626.

(there's still some debate in that issue, but that's orthogonal to writing code to do what that feature request asks)

Copy link
Member

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's important to change the column ordering so that the address goes last:

Number
Date
Hash
Full Address

Now that it's longer this means the overflow will just run off and clip / scroll horizontally, so it's like a short form (until you want to look at it)

@cronokirby cronokirby merged commit c000584 into main Jan 25, 2024
7 checks passed
@cronokirby cronokirby deleted the summonerd-full-address branch January 25, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change summoner web interface to have full addresses
2 participants