pd: 👏 cli commands and options live in pd::cli
#3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
A-node
this commit is pure code motion. this moves the `Opt` clap argument parser and option/command definitions to a `pd::cli` submodule. this will help with integration testing of `pd` someday, and helps keep our entrypoint tidy.
cratelyn
force-pushed
the
katie/cli-commands-in-pd-lib
branch
from
49d4142 to
708f7eb
Compare
|
force-pushed, cargo fmt. |
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit is pure code motion. this moves the
Optclap argument parser and option/command definitions to apd::clisubmodule. this will help with integration testing ofpdsomeday, and helps keep our entrypoint tidy. (see #3588 for other work related to future integration tests)