penumbra-ibc: ⏎ invert early return condition #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this diff is best viewed ignoring whitespace; use `-w`, or the "_hide whitespace_" option in github (the gear icon in the "_files changed_" tab). this inverts our early return, so that we do not need to wrap the whole function body within a conditional block. this is a pure refactor that should have no visible changes to behavior.
cratelyn
added
A-IBC
erwanor
approved these changes
Jan 29, 2024
|
re, lint failing, that is happening upstream on |
|
lint was kindly fixed in #3692, i am going to merge this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this diff is best viewed ignoring whitespace; use
-w, or the "hide whitespace" option in github (the gear icon in the "files changed" tab).this inverts our early return, so that we do not need to wrap the whole function body within a conditional block. this is a pure refactor that should have no visible changes to behavior.