penumbra: remove chain component and move epoch management to SCT #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
force-pushed
the
erwan/3617_part_2_app_params
branch
from
154ffc5 to
c911e9e
Compare
erwanor
changed the title
erwanor
force-pushed
the
erwan/3617_part_2_app_params
branch
from
12f1f0f to
152859c
Compare
|
This compiles, so this is a good time to pause for now. My remaining task:
I am going to let the CI run overnight. Since the view service is broken any tests that exercise claiming should not pass. However, I think the rest of the CI should pass. We're so close! |
erwanor
force-pushed
the
erwan/3617_part_2_app_params
branch
from
f10d718 to
5f218f4
Compare
The original schema had a kv table, it's much simpler to do it this way than to manifest our data structures again in the form of a SQL schema.
|
Excellent, the test suite and smoke tests are passing! Marking this as ready-for-review, now I want to:
|
This was referenced Jan 31, 2024
|
Merging this large PR optimistically so that integration work can proceed and to minimize conflicts. Follow-up tasks are tracked in independent issues that we are tackling today. Also working on a release tracking list for testnet 65. |
TalDerei
pushed a commit
that referenced
this pull request
Feb 8, 2024
* sct: add `SctParameters` to track epoch/time config * governance(proto): move `Ratio` to gov component * governance(tally): local `Ratio` computation * sct(component): expose `params` module * sct(params): add docstrings to `SctParameters` * chain: remove `ChainParameters`! * sct(proto): add sct param message definition * sct(proto): define `Epoch` * app: prelude to including `SctParameters` * chain: remove genesis module * sct(epoch): define epoch structure in sct component * sct: define sct query service api * proto: remove chain all chain component messages * sct(proto): add genesis message * app(proto): add sct genesis content to messages * governance(proto): remove dep on obsolete chain protos * app(proto): fix missing type * proto-compiler: remove `chain` from targets * penumbra: generate interfaces without the chain messages * sct: add genesis module * app(proto): add chain id to app param message * chain: remove `params`, `genesis * penumbra: generate protos with chain id in app params * sct: implement simple query service for epochs * chain: remove rpc module * chain: remove epoch module * sct(state_key): define `block_manager` and `epoch_manager` namespaces * chain: remove state keys and R/W ext traits * penumbra: remove the chain component * penumbra: remove chain component from workspace * app: add `chain_id` methods * app(state_key): namespace state keys by domain * app: move cometbft prefix to `lib` * sct: handle epoch and block timestamp management * penumbra: remove all dep imports of `penumbra-chain` * penumbra: untangle dependency build up on `penumbra-chain` * penumbra: second pass at fixing build errors (wip) * penumbra: third pass at fixing various build errors (wip) * shielded-pool: scaffolding for shielded pool parameters * shielded-pool(proto): define `ShieldedPoolParameters` message * governance(proto): update changed app params * penumbra: propagate api changes * buf: lint protos * penumbra: regenerate protos with shielded pool params * app(proto): add shielded pool params to app params * penumbra: third pass on the changed app params workflow * penumbra: regenerate protos * penumbra: progress through removing usage of `ChainParameters` * penumbra: update the wasm planner and view services * penumbra: run `fmt` * ci: remove p-chain from rustdocs * app(host_chain): reimplement the host chain interface * app(host_chain): comment impl * view: simplify the plan method * transaction(gas): make compact block cost zero for proposals * penumbra: remove obsolete comments * penumbra: run `fmt` * transaction(gas): remove unused imports * app: fix `get_chain_id` * shielded-pool: finalize genesis content struct * shielded-pool(proto): add params to protos * penumbra: refresh protos to account for changes * governance: fix halt count logic * app: init sct params * view: go back to having a kv table The original schema had a kv table, it's much simpler to do it this way than to manifest our data structures again in the form of a SQL schema. * view: remove unused deps * view(storage): fix unused imports p2 --------- Co-authored-by: Henry de Valence <hdevalence@penumbralabs.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3617, this PR is a work-in-progress:
ChainParametersstructure intoAppParameters(chain id) andSctParameters(epoch window config)This last step is critical, because it means that the final next iteration of this work can happen independently of other integration work streams.