feat(pd): allow use of staging api for letsencrypt #3705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3681.
To test, I provisioned a machine on with DNS on a test domain (to reduce side-effects in case it was broken, and the requested domain got ratelimited):
I also confirmed that when run as a normal user, the bind to 443 fails with an error message:
That logic hasn't changed in this PR, but the new output validates that #3555 is working as expected.