Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: 🔐 extract auto-https into a standalone crate #3714

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

cratelyn
Copy link
Contributor

fixes #3119. see also, #1886.

this pulls the auto-https code (see #3627, #3652) into a standalone library crate.

fixes #3119. see also, #1886.

this pulls the auto-https code (see #3627, #3652) into a standalone
library crate.
@cratelyn cratelyn added A-node Area: System design and implementation for node software E-easy Effort: Easy labels Jan 31, 2024
@cratelyn cratelyn self-assigned this Jan 31, 2024
@cratelyn cratelyn marked this pull request as ready for review January 31, 2024 19:11
@cratelyn cratelyn requested a review from conorsch January 31, 2024 19:43
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I haven't functionally verified that there's no breakage, but the diff is clean and readable. Post-merge I'll rebase the WIP #3709 and resume testing.

@conorsch conorsch merged commit feb5958 into main Jan 31, 2024
7 checks passed
@conorsch conorsch deleted the katie/extract-auto-https branch January 31, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-node Area: System design and implementation for node software E-easy Effort: Easy
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Extract pd auto-https code into standalone utility crate, or else make it unnecessary
2 participants