Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view: auto-restart view worker on error #3730

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

hdevalence
Copy link
Member

Currently, any transient error in the view worker permanently stops the server forever. Instead, restart after a delay.

@conorsch
Copy link
Contributor

conorsch commented Feb 2, 2024

Refs #3732

@cronokirby
Copy link
Contributor

cronokirby commented Feb 2, 2024

We should revisit the use of error_slot and how the status of the view service is reported in other methods, otherwise I anticipate confusion when an upstream caller looks at the status during the sleep. Right now, the various methods for implementing ViewProtocolService will check the error slot, and fail if it's currently set, and so during the sleep period all these methods will fail.

In general, what should we do during the phase where the ViewService is restarting? Should the various service methods fail? Are callers supposed to know that they'll work soon? Should we have the methods block? Should we have them return stale answers?

@hdevalence
Copy link
Member Author

Yeah, agreed that those are all tricky things. I think what we want to do is have a health check method that allows the caller to see if the service is healthy or not. There's one example of how to do an "internal" health check method in Hermes, though we might want something slightly different.

In the meantime I think we should merge this and track that separately.

@hdevalence hdevalence merged commit 5ac1be2 into main Feb 3, 2024
7 checks passed
@hdevalence hdevalence deleted the view-server-restart branch February 3, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants