feat(pcli): default coordinator address for ceremony #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
reviewed
Feb 5, 2024
cronokirby
force-pushed
the
summonerd-default-coordinator-address
branch
from
fcc189c to
b20e1a2
Compare
|
(ran rustfmt in an amended commit) |
During Phase 1 of the summoning ceremony, some contributors were confused about the `--coordinator-address` flag, and incorrectly overrode it to a wallet address they control. Let's set a sane default value for that arg, and remove its display from the web page.
conorsch
force-pushed
the
summonerd-default-coordinator-address
branch
from
b20e1a2 to
0fde002
Compare
|
I superfluously rebased because the CI badges were stuck. Thanks for handling, @cronokirby! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Phase 1 of the summoning ceremony, some contributors were confused about the
--coordinator-addressflag, and incorrectly overrode it to a wallet address they control. Let's set a sane default value for that arg, and remove its display from the web page.