feat(proto): bump v1alpha1 -> v1 throughout #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
bump-protos-to-v1
branch
from
e98fd13 to
60afbb7
Compare
conorsch
force-pushed
the
bump-protos-to-v1
branch
from
60afbb7 to
092754b
Compare
We originally added the golang codegen to provide first-class support to downstream integrators. This is no longer necessary, as those same integrators, e.g. Strangelove, are performing their own codegen in the respective repos. These codepaths in the Penumbra monorepo are unused and largely unmaintained, so I'm culling them. Refs #2184. Moots and therefore closes #2731.
It's happening~~. We're marking the current suite of protobuf definitions as "v1", implying they're stable enough. Going forward, breaking changes must be made in a v2 directory. We're merging this change ahead of Testnet 65 (#3554).
conorsch
force-pushed
the
bump-protos-to-v1
branch
from
092754b to
3dd7bb3
Compare
|
CI is most definitely failing on the buf lint job:
Yes, that's to be expected. Technically we could opt to preserve the |
conorsch
added a commit
to penumbra-zone/galileo
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's happening~~. We're marking the current suite of protobuf definitions as "v1", implying they're stable enough. Going forward, breaking changes must be made in a v2 directory.