tests: 🍱 hoist ABCI server into penumbra-app
#3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now, the logic to instantiate an abci server lives in the penumbra-app crate. this will be useful for our later efforts w.r.t. app testing.
as a consequence of not needing to be exported across a crate boundary, we can see the `index_none` constructor is never used. remove it, to address a dead code warning. an import is formatted too here, sorry about that!
cratelyn
changed the title
penumbra-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3695.
see #3588.
this performs a series of changes to facilitate the instantiation of an ABCI service in tests. in #3789, we hoisted the
ConsensusandMempoolservices out of thepdlibrary and intopenumbra-app. this continues that work, movingInfoandSnapshot, as well as theEventIndexLayermiddleware.this allows us to move the logic in
pd's entrypoint responsible for building and spawning an ABCI server to run in the background, exposing this instead from thepenumbra-applibrary.this represents the last piece of work in #3695, and sets the stage for a test node that contains that ABCI task and an accompanying mock consensus engine. see #3787 for an issue tracking the remaining work to initialize a test node. see #3788 for an issue tracking the work to port existing state machine tests to use a mock consensus engine.