Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: change BalancesResponse to have Views #3824

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

hdevalence
Copy link
Member

@hdevalence hdevalence commented Feb 14, 2024

This will enable using denom metadata in the frontend's asset view.

grod220
grod220 previously approved these changes Feb 15, 2024
@grod220 grod220 changed the title [wip] proto: change BalancesResponse to have Views proto: change BalancesResponse to have Views Feb 23, 2024
@grod220 grod220 dismissed their stale review February 23, 2024 15:12

Added the implementation, going to re-request review

@grod220
Copy link
Contributor

grod220 commented Feb 23, 2024

There are various import re-arranging and code formatting that it appears RustRover did along the way. Can revert those if it's beyond the scope of this, but it makes sense to me.

@grod220 grod220 marked this pull request as ready for review February 23, 2024 15:23
Copy link
Member Author

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdevalence hdevalence merged commit 44d30db into main Feb 26, 2024
6 checks passed
@hdevalence hdevalence deleted the balances-req-view branch February 26, 2024 06:15
@cratelyn cratelyn added the protobuf-changes Makes changes to the protobuf definitions. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf-changes Makes changes to the protobuf definitions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants