dex: replace PositionRewardClaim by repeated PositionWithdrawal #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Error
hdevalence
force-pushed
the
lpnft-withdrawn-seq
branch
from
81916da to
64137a6
Compare
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
In addition to existing unit tests, I verified that |
|
ACK on mechanism, i think this is great and the state reduction is appreciated. I want to give it a more thorough review later today, but this should make it into 68. |
|
Closes #3851 as a side effect. |
Instead of having a separate reward claim action that can only be performed once, we can add a sequence number to the withdrawn position NFT, allowing multiple withdrawals.
hdevalence
force-pushed
the
lpnft-withdrawn-seq
branch
from
7784894 to
e8ff591
Compare
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a separate reward claim action that can only be performed once, we can add a sequence number to the withdrawn position NFT, allowing multiple withdrawals.