staking: remove component::FP_SCALING_FACTOR dup
#3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging, can we
|
errors at least local to the crate now |
|
made one minor change, building successfully with a dep on this branch, will PR in web repo in a sec |
jk it works
|
turbocrime
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
@turbocrime oh great, is that screenshot also indicating that the updated proof params work with |
they work enough to make a send tx, yes |
turbocrime
force-pushed
the
erwan/move_scaling_factor
branch
from
51970b7 to
f95dae8
Compare
turbocrime
had a problem deploying
to
smoke-test
GitHub Actions
Error
turbocrime
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
2 tasks
cratelyn
added a commit
that referenced
this pull request
Mar 7, 2024
performs the same cleanup as #3895, but for the `penumbra-app` crate's manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the wasm build unless something else is wrong. The problem was that we defined the same constant (
FP_SCALING_FACTOR) twice, once correctly at the crate-level, and another one inpenumbra_stake::component. During development, the latter one was used and created a discreet dependency on the component module.x-ref #3894