Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcli: improve pcli ibc channel queries #3906

Merged
merged 2 commits into from
Mar 1, 2024
Merged

pcli: improve pcli ibc channel queries #3906

merged 2 commits into from
Mar 1, 2024

Conversation

avahowell
Copy link
Contributor

@avahowell avahowell commented Feb 28, 2024

Closes #3905

This PR makes the pcli channel queries more useful to the end user, displaying relevant channel metadata (like chain ID) instead of just dumping the protocol level struct to console as JSON.

Before:

Screenshot 2024-02-27 at 17 59 10

After:

Screenshot 2024-02-27 at 18 00 44

Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎇 the table presentation is so comfy! 😍

@cratelyn cratelyn added A-IBC Area: IBC integration with Penumbra C-enhancement Category: an enhancement to the codebase labels Feb 28, 2024
@cratelyn cratelyn added this to the Sprint 1 milestone Feb 28, 2024
@avahowell avahowell merged commit 553b344 into main Mar 1, 2024
6 checks passed
@avahowell avahowell deleted the better-ibc-pcli branch March 1, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-IBC Area: IBC integration with Penumbra C-enhancement Category: an enhancement to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make pcli ibc query commands more concise and useful
2 participants