Add undelegate claims to TransactionPlannerRequest #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
changed the title
jessepinho
force-pushed
the
jessepinho/web-655-undelegate-claims
branch
from
f302c7e to
6999a2d
Compare
jessepinho
changed the title
jessepinho
force-pushed
the
jessepinho/web-655-undelegate-claims
branch
from
29dd55b to
14450e9
Compare
jessepinho
added
A-staking
3 tasks
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undelegate claims are currently unsupported in
TransactionPlannerRequests. This PR fixes that. Relevant changes are here; everything else is generated by the protobuf codegen script.Note that the
UndelegateClaimmessage leaves out theblindingfields, so that the RPC method implementation can fill those in on behalf of the client. (In the case of the web app, this means that the WASM planner will fill those in, rather than the web app.)I'm less familiar with the core repo, so please let me know if I've missed anything.