stake: fix missing index and simplify state machine #3928

erwanor · 2024-03-03T16:45:43Z

This PR:

fix a bug that would cause unjailed validators to not be re-added to the consensus index
simplify the validator state machine, and in particular:
- move the state effect outside of the match implementation
- unify valid, but no-op, branches (e.g. Disabled <> Defined)
- improve and elaborate comments

erwanor temporarily deployed to smoke-test March 3, 2024 16:45 — with GitHub Actions Inactive

cratelyn added the A-staking Area: Design and implementation of staking and delegation label Mar 4, 2024

erwanor requested a review from cratelyn March 5, 2024 21:53

cratelyn approved these changes Mar 7, 2024

View reviewed changes

erwanor added the consensus-breaking breaking change to execution of on-chain data label Mar 8, 2024

erwanor and others added 8 commits March 10, 2024 16:41

staking: fix/simplify validator state machine

11d77b8

staking: update tombstoning comment

5589517

stake: add comment on process_chain_base_rate

3c8725f

stake: add comment on belongs_in_index`

9872fd5

stake: simplify validator manager even more

11785cb

stake: use ensure! in definition check

1c0206d

stake: improve validator manager comments

bc6f128

stake: clean-up add_validator_inner

d3cc132

erwanor force-pushed the erwan/stake_index_fix branch from bff19de to d3cc132 Compare March 10, 2024 20:45

erwanor temporarily deployed to smoke-test March 10, 2024 20:45 — with GitHub Actions Inactive

erwanor merged commit dbba4fa into main Mar 10, 2024
6 checks passed

erwanor deleted the erwan/stake_index_fix branch March 10, 2024 21:49

Provide feedback