dex: fix chain halt in testnet 68 #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testnet 68 halted at height 100736, with an `.expect` here: https://github.com/penumbra-zone/penumbra/blob/1c99e24ad5cf1ecc2855849d66221ecec25f9235/crates/core/component/dex/src/component/dex.rs#L66 This hit an error bubbled up from here: https://github.com/penumbra-zone/penumbra/blob/1c99e24ad5cf1ecc2855849d66221ecec25f9235/crates/core/component/dex/src/component/router/route_and_fill.rs#L277 The error occurs in this method, which is only ever used at that callsite: https://github.com/penumbra-zone/penumbra/blob/1c99e24ad5cf1ecc2855849d66221ecec25f9235/crates/core/component/dex/src/swap_execution.rs#L18 It's a little unclear why that method has double fallibility. Unfortunately, the answer may not be easily determined. It was added here 9cd566d which indicates that there was previously an infallible `max_price`, but that code isn't included in the commit; the previous reference to an infallible `max_price` was added in this commit b4b2635 which doesn't have the impl either, so presumably it got mangled during rebasing. In any case, removing the double fallibility, as in this commit, allows committing block 100736 on testnet 68, which I verified by running this code against a local copy of a state snapshot.
|
I opened this against the release branch, for ease of making a point release, we'd eventually want to land it in main. |
erwanor
approved these changes
Mar 5, 2024
conorsch
approved these changes
Mar 5, 2024
erwanor
added
the
zellic-component-remediated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testnet 68 halted at height 100736, with an
.expecthere:penumbra/crates/core/component/dex/src/component/dex.rs
Line 66 in 1c99e24
This hit an error bubbled up from here:
penumbra/crates/core/component/dex/src/component/router/route_and_fill.rs
Line 277 in 1c99e24
The error occurs in this method, which is only ever used at that callsite:
penumbra/crates/core/component/dex/src/swap_execution.rs
Line 18 in 1c99e24
It's a little unclear why that method has double fallibility. Unfortunately, the answer may not be easily determined. It was added here
9cd566d
which indicates that there was previously an infallible
max_price, but that code isn't included in the commit; the previous reference to an infalliblemax_pricewas added in this commitb4b2635
which doesn't have the impl either, so presumably it got mangled during rebasing.
In any case, removing the double fallibility, as in this commit, allows committing block 100736 on testnet 68, which I verified by running this code against a local copy of a state snapshot.