-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pd: 📦 add a tracing event with cargo version #3952
Conversation
this adds a small tracing event including the version of pd that is running, before proceeding to handle the CLI command. this should help operators identify when they are running a stale version of pd.
Maybe I'm missing something — this doesn't actually do what we want, right? That environment variable is set by Cargo when running Cargo, not when running pd... |
to my understanding, this would log versions like in the interest of disambiguating whether a stale |
My read of that page is that it's set by cargo, not embedded in the binary. But an easy way to test would be to run the binary ./target/release/pd and see. |
i confirmed this works properly with a small test program:
|
Ah great! This is much simpler than I'd expected then, thanks for getting it merged in! |
this adds a small tracing event including the version of pd that is running, before proceeding to handle the CLI command. this should help operators identify when they are running a stale version of pd. (cherry picked from commit adb8e59)
this adds a small tracing event including the version of pd that is running, before proceeding to handle the CLI command. this should help operators identify when they are running a stale version of pd. (cherry picked from commit adb8e59)
this adds a small tracing event including the version of pd that is running, before proceeding to handle the CLI command.
this should help operators identify when they are running a stale version of pd.