ibc: show client expiry status in channel query #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
approved these changes
Mar 5, 2024
cratelyn
added
A-IBC
cratelyn
reviewed
Mar 5, 2024
Comment on lines
+182
to
+191
| let mut state_str = State::from_i32(channel.state).unwrap().to_string(); | ||
|
|
||
| let current_time: time::OffsetDateTime = SystemTime::now().into(); | ||
| let current_time_tm: tendermint::Time = current_time.try_into()?; | ||
|
|
||
| let time_elapsed = | ||
| current_time_tm.duration_since(tendermint_consensus_state.timestamp)?; | ||
| if client_state.expired(time_elapsed) { | ||
| state_str = "CLIENT EXPIRED".to_string(); | ||
| } |
There was a problem hiding this comment.
this block is more or less duplicated further down on line 273. it'd be nice* to factor this out into a small helper function or method of tendermint_consensus_state that would do this for us.
expired is already there, so maybe client_state.is_now_expired() -> bool could just use SystemTime::now() and then call expired.
* i shan't block on this, but noticed the duplication
|
For comparison's sake, here's what the change looks like. Before:
###After: Note that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
ibc q channel(s)so that it will show the status as 'CLIENT EXPIRED' if the underlying client for a channel has expired.