Prepare changeset for v0.68.3 release #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 220e620)
(cherry picked from commit 4fca2ac)
I added the `EquivalentPrice` to the asset proto package rather than solely in the TxP, because I realized that the use cases we care about most immediately (having equivalent prices for balances) don't actually involve `TransactionView`s at all. While doing that I realized that in the context of viewing a _transaction_, it doesn't really make sense to just have an "equivalent value" on its own, so I added an `as_of_height` to allow indicating when the prices were relevant. We probably shouldn't try to expose this in the transaction view just yet, since it's a little unclear how we'd want to indicate historical prices. (cherry picked from commit 1e19b9b)
conorsch
force-pushed
the
prepare-changeset-for-0.68.3
branch
from
43beafa to
a3842e5
Compare
(cherry picked from commit d3bbe4c)
this adds a small tracing event including the version of pd that is running, before proceeding to handle the CLI command. this should help operators identify when they are running a stale version of pd. (cherry picked from commit adb8e59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains cherry-picked commits intended for inclusion in v0.68.3, targeting the release branch for same. These commits are based on the following PRs:
ValueView#3898