tests(pcli): 🔇 make large tracing event trace-level #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are two issues at hand: - we log `undelegation_result` twice - `undelegation_result` can be many thousands of lines long this means that the `delegate_and_undelegate` pcli network integration test thrashes the test output somewhat severely, and test logs aren't fully viewable in e.g. tmux, when running this locally. https://github.com/penumbra-zone/penumbra/actions/runs/8210700115/job/22458602964#step:11:18 as of `main` at the time of writing, this CI job logs an event that is... ``` ; xclip -o -selection clipboard | wc --bytes 243775 ``` 243Kb is disruptively long. (_let alone 486Kb!_) so, let's make this field an opt-in field to display. we only log it once, and do so at the trace level.
cratelyn
added
C-chore
erwanor
approved these changes
Mar 10, 2024
nice! i removed it in 85fa01b, thank you for the suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are two issues at hand:
undelegation_resulttwiceundelegation_resultcan be many thousands of lines longthis means that the
delegate_and_undelegatepcli network integration test thrashes the test output somewhat severely, and test logs aren't fully viewable in e.g. tmux, when running this locally.https://github.com/penumbra-zone/penumbra/actions/runs/8210700115/job/22458602964#step:11:18
as of
mainat the time of writing, this CI job logs an event that is...243Kb is disruptively long. (let alone 486Kb!)
so, let's make this field an opt-in field to display. we only log it once, and do so at the trace level.
Checklist before requesting a review