tests(app): 🧪 test that uptime tracks signed blocks #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
A-testing
This was referenced Mar 21, 2024
cratelyn
force-pushed
the
kate/mock-consensus-validator-uptime-signatures
branch
from
747043b to
97b8ace
Compare
cratelyn
force-pushed
the
kate/mock-consensus-validator-uptime-signatures
branch
from
9c675f9 to
2efe2de
Compare
cratelyn
force-pushed
the
kate/mock-consensus-validator-uptime-signatures
branch
from
2efe2de to
bcdf647
Compare
cratelyn
force-pushed
the
kate/mock-consensus-validator-uptime-signatures
branch
from
bcdf647 to
19e01d1
Compare
cratelyn
force-pushed
the
kate/mock-consensus-validator-uptime-signatures
branch
from
19e01d1 to
49660e2
Compare
This was referenced Mar 25, 2024
this changes the mock consensus test node s.t. it includes commit signatures from all validators in the keyring. the app does not validate that signatures are well formed, so empty vote information is provided for now. --- * this adds a signatures field to the block `Builder` so that we can manipulate the list of validator signatures in a block to be built by the mock consensus engine. * a `with_signatures` block builder method is added to manipulate that field. * `LastCommitInfo` is now constructed from the list of signatures. --- some todo's about potential upstream patches are left where applicable.
now that we sign blocks by default, this should be a 0. the validator hasn't missed any blocks.
cratelyn
force-pushed
the
kate/mock-consensus-validator-uptime-signatures
branch
from
49660e2 to
00e23f5
Compare
|
rebased now that #4099 has landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: this is based on #4099.
this adds test coverage, complementary to the work in #4061, which asserts that we properly track the affirmative case of validators signing blocks.
fixes #4040. see #3995.