Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fee: gate penumbra-proto/rpc on component feature #4114

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Mar 27, 2024

After deploying testnet 70, we discovered that an OS specific crate popped up in the dependency tree of the wasm crate (used by the web extension). We typically use the component feature to prevent this from happening (e.g. mio relies on a variety of platform specific syscalls that simply don't exist in a wasm environment) but one slipped through.

@cratelyn cratelyn added the A-wasm Area: Related to WebAssembly components label Mar 27, 2024
@cratelyn cratelyn added this to the Sprint 3 milestone Mar 27, 2024
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@erwanor erwanor merged commit 0505885 into main Mar 27, 2024
7 checks passed
@erwanor erwanor deleted the erwan/fix_wasm_dep_fee branch March 27, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-wasm Area: Related to WebAssembly components
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants