fees: add per-action block space calculations & representative values #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubrika
force-pushed
the
3940-remove-tx-wide-costs
branch
from
d93f3c9 to
e66d183
Compare
aubrika
force-pushed
the
3940-remove-tx-wide-costs
branch
from
e66d183 to
b14147c
Compare
|
Added some approximate block space estimates based on the proto fields, but for some data types (e.g. bytes, string) of variable size, I'm unsure if the chosen values (64 bytes?) are good approximations - do you have thoughts @hdevalence ? Also, are there any actions for which this draft is currently computing the length of the encoding which should be hard-coded? I chose the set of actions with bespoke associated |
hdevalence
reviewed
Mar 28, 2024
hdevalence
reviewed
Mar 28, 2024
hdevalence
reviewed
Mar 28, 2024
There was a problem hiding this comment.
The numbers seem plausible, it would be good to have comments clarifying:
- what is being added up
- why we are not concerned about the exact byte size for the fixed-size actions (e.g., why it's ok to ignore protobuf framing), namely that it makes only a small difference in the action's gas cost and simplifies the accounting
aubrika
force-pushed
the
3940-remove-tx-wide-costs
branch
from
b14147c to
ff23599
Compare
aubrika
force-pushed
the
3940-remove-tx-wide-costs
branch
from
ff23599 to
b00c0b8
Compare
aubrika
force-pushed
the
3940-remove-tx-wide-costs
branch
from
b00c0b8 to
6b72b7b
Compare
…, fix proto comment on OutputBody size
aubrika
force-pushed
the
3940-remove-tx-wide-costs
branch
from
6b72b7b to
8a0478b
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft example of current best interpretation for #3940 - any Action with a bespoke ActionPlan is currently given a block space value of "64" as a placeholder, but obviously that needs to change, just unsure how based on previous ticket comments.