-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add component contract check #4117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for this!
232475e
to
d61dae8
Compare
0f763d9
to
7656082
Compare
7656082
to
c9bf6fd
Compare
This CI check runs with Therefore I think the sanest strategy we can have to prevent breakage is:
Anything else is prone to breakage without us noticing. I'll pop into web sync tomorrow to ask for more detail; I know you and @jessepinho already spoke a lot about this! |
Respectfully disagree, we should have a check that our core crates, in particular the The wasm crate is the primary consumer of the penumbra core crates, but there could be many more and we want to allow tooling to be possible to build by default. There are two crates that the wasm crate import with |
c9bf6fd
to
3bd9604
Compare
Back in [0] we removed the wasm crate from the monorepo, so that the web team could own it and iterate more quickly. We also purged associated testing, however, so we missed some breakage around the release of v0.70.0. This check attempts to restore some visibility into the potential of breaking APIs relevant to web work. [0] #3819
3bd9604
to
f90a801
Compare
Discussed this OOB with @erwanor, and we're both happy with the changes here. |
This add a quick
cargo check
to avoid leaking platform specific dependencies in our workspace, and breaking downstream dependencies like thewasm
crate used by the extension.The script itself could be refactored into a one-liner, but the current structure makes it easy to observe which crate fails to build for the special target.