Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto(view): deprecate start_epoch_index #4119

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Mar 27, 2024

@jessepinho noticed that a submessage of the TransactionPlannerRequest envelope should be deprecated and replaced by a height field.

This PR:

  • deprecate TransactionPlannerRequest.UndelegateClaim.start_epoch_index
  • adds TransactionPlannerRequest.UndelegateClaim.unbonding_start_height
  • regenerate the protos

@erwanor erwanor added the protobuf-changes Makes changes to the protobuf definitions. label Mar 27, 2024
@erwanor erwanor requested review from conorsch and jessepinho March 27, 2024 19:00
Copy link
Contributor

@jessepinho jessepinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 it

@erwanor erwanor added this to the Sprint 3 milestone Mar 27, 2024
@jessepinho jessepinho merged commit 8b7f552 into main Mar 27, 2024
7 checks passed
@jessepinho jessepinho deleted the erwan/planner_protos_fix branch March 27, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf-changes Makes changes to the protobuf definitions.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants