Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minifront/node-status apps #4132

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Update minifront/node-status apps #4132

merged 1 commit into from
Mar 29, 2024

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Mar 28, 2024

Describe your changes

Pulls in the build outputs of the node-status and minifront apps.

@conorsch
Copy link
Contributor

At a glance, looks like you don't have git-lfs setup for this repo. The *.zip files within the assets/ dir should be using git lfs, and it looks like they're raw bin files here. See the (rather sparse) git-lfs docs here: https://guide.penumbra.zone/main/dev/build.html I'd be happy to pair with you to sort it out!

@conorsch
Copy link
Contributor

I'd be happy to pair with you to sort it out!

We straightened this out: CI should pass now.

@jessepinho jessepinho marked this pull request as ready for review March 28, 2024 22:33
@erwanor erwanor merged commit 8055b85 into main Mar 29, 2024
7 checks passed
@erwanor erwanor deleted the jessepinho/update-apps branch March 29, 2024 14:44
@conorsch
Copy link
Contributor

Merging this PR broke serving minifront on the pd grpc endpoint:

❯ curl -I https://grpc.testnet-preview.penumbra.zone/
HTTP/2 404
access-control-allow-origin: *
access-control-expose-headers: *
date: Fri, 29 Mar 2024 17:48:19 GMT
vary: origin
vary: access-control-request-method
vary: access-control-request-headers
content-length: 25

Is it possible that a different procedure was used for generating the zipfile? Can we script that process so it's on-rails?

conorsch pushed a commit that referenced this pull request Mar 30, 2024
Follow-up to #4132, in which we updated the minifront assets
but mistakenly with the wrong subdir nesting. This broke serving
minifront from pd's gRPC endpoint, but our tests didn't catch that,
so we only noticed when it hit preview.

Added a test to the pd integration suite as a sanity check.
Made sure to confirm that the test fails on current main, and passes
with the asset fix included in this commit.

Squashed and committed by @conorsch.
conorsch pushed a commit that referenced this pull request Mar 30, 2024
Follow-up to #4132, in which we updated the minifront assets
but mistakenly with the wrong subdir nesting. This broke serving
minifront from pd's gRPC endpoint, but our tests didn't catch that,
so we only noticed when it hit preview.

Added a test to the pd integration suite as a sanity check.
Made sure to confirm that the test fails on current main, and passes
with the asset fix included in this commit.

Squashed and committed by @conorsch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants