Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto(stake): add doc to RateData.validator_exchange_rate #4134

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Mar 28, 2024

Describe your changes

This wasn't documented before, which made it hard to understand what the number meant.

@jessepinho jessepinho marked this pull request as ready for review March 28, 2024 21:18
@erwanor erwanor changed the title Document the validator_exchange_rate property proto(stake): add doc to RateData.validator_exchange_rate Mar 28, 2024
Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge on green CI!

@erwanor erwanor merged commit 3155af1 into main Mar 28, 2024
7 checks passed
@erwanor erwanor deleted the jessepinho/document-exchange-rate branch March 28, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants